dialogflow-javascript-client icon indicating copy to clipboard operation
dialogflow-javascript-client copied to clipboard

Wip/25 add gain node

Open muuki88 opened this issue 8 years ago • 5 comments

I added a minimal working solution for a gainNode. Tested on Google Chrome 56.0.2924.87 (64-bit) / Ubuntu 16.10. See #25

  • [x] Make gainNode configurable
  • [ ] Provide a test
  • [ ] Test on more browsers

muuki88 avatar Feb 19 '17 11:02 muuki88

Sorry, I created the PR from the wrong branch on my fork.

I added a gain option to the IStreamClientOptions. Testing with the demo/typescript-project wasn't possible as it depends an actual deployed version. How to you test this locally?

muuki88 avatar Feb 19 '17 11:02 muuki88

To test if typescript-project works fine, you can use npm pack (which creates .tgz) + npm install (local tgz)

Considering your pull request: i thought that it should be possible to tune gainNode value "in runtime", not only during initialization. To make "mute" function or something like that. Correct me if i wrong.

And thank you for your work.

Gugic avatar Feb 20 '17 20:02 Gugic

i thought that it should be possible to tune gainNode value "in runtime", not only during initialization. To make "mute" function or something like that

Sounds like a good idea :) Will work on that ASAP

And thanks for the hint on how to test this locally. Wouldn't it be possible to reference it by going up the directory a few steps?

muuki88 avatar Feb 22 '17 17:02 muuki88

This is probably possible, but partially ignores node mechanism of modules resolve. You may be can also try this (https://docs.npmjs.com/cli/link)

Considering making it configurable, i think you can just add method like getGainNode to interface that will return existing gain node and that will allow users to manage it in any desired way. (probably we can also remove new 'gain' property from option).

What do you think about that?

Gugic avatar Feb 22 '17 18:02 Gugic

Considering making it configurable, i think you can just add method like getGainNode to interface that will return existing gain node and that will allow users to manage it in any desired way. (probably we can also remove new 'gain' property from option)

Sounds good to me. Will change ASAP

muuki88 avatar Feb 22 '17 19:02 muuki88