Dhruv Bhanushali

Results 274 comments of Dhruv Bhanushali

Aggregate reports over a fixed time interval seems like a good idea. Adding an endpoint to `analytics` for content reports seems like a good way forward, considering that it has...

`analytics` writes event rows to the same database as the API.

@sarayourfriend I support this solution. Minio is great and while we do somewhat support running the API outside Docker, we still need the scaffolding services to be provisioned by Docker...

@sarayourfriend this is true for unit tests but integration tests should be using the actual underlying database so that we can ensure that the overall behaviour works as expected. In...

Interacting with the production database for running tests seems wrong. Why not just use the sample entries set up by `just init` for the tests?

Oh no @sarayourfriend I completely agree that tests like the ones in #553 are not ideal. But as it stands right now, the API completely relies on the sample data...

@Prakharkarsh1 please go ahead. Feel free to comment here or alteratively ask in the #openverse channel in the [Making WordPress Slack workspace](https://make.wordpress.org/chat/) if you need help.

Can be related with #181 to make the examples work as test cases.

If this goes well, this should also fix WordPress/openverse#699.

@Vidush22 sure, go ahead. Feel free to ping here on post in the #openverse channel in the [Making WordPress Slack workspace](https://make.wordpress.org/chat/) if you need any help.