spa-eye icon indicating copy to clipboard operation
spa-eye copied to clipboard

Not compatible with Firebug 2

Open janodvarko opened this issue 10 years ago • 14 comments

I am seeing an error (in FBTrace console): mini-require; EXCEPTION lookup TypeError: Firebug.ScriptPanel is undefined chrome://spa_eye/content/spa_eyePanel.js:377 (13) resource://firebug/mini-require.js:88 (13) chrome://spa_eye/content/spa_eyePanel.js:31 (1)

The ScriptPanel is no longer exposed through Firebug namespace. You need to specify it in the list of dep modules

require "firebug/debugger/script/scriptPanel" and use it.

Honza

janodvarko avatar Jun 06 '14 12:06 janodvarko

Thanks @janodvarko for writing in! I will fix it when we make the plugin compatible with Firebug 2

dhruvaray avatar Jun 09 '14 13:06 dhruvaray

Awesome!

Firebug 2.0 final should be available on AMO tomorrow.

Honza

janodvarko avatar Jun 09 '14 14:06 janodvarko

Not directly related, but is support for Firefox 30.0 on the way as well?

Kudos for all the hard you've put in!

hovsater avatar Jun 14 '14 14:06 hovsater

@KevinSjoberg : With the latest commits I just made, it seems to be mostly working with Firebug 2.0 & FF 30.0. If you are eager, you can always build your own copy of the xpi fairly easily by following the instructions here.

@janodvarko :

  • I see that you have kept domReps for backword compatibility with spa-eye. Thanks! I need to revisit usage of domReps moving forward. But the plug-in seems to be mostly working now.
  • I may have to revisit the following snippet for JSD2 compat/best practices

this.jsd = DebuggerService.getService(jsdIDebuggerService);
this.jsd.functionHook = { onCall: this.onFunction };

...
...
onFunction:function (frame, type) {
switch (type) {
  case TYPE_FUNCTION_RETURN:
    var scope = Wrapper.unwrapIValue(frame.scope, Firebug.viewChrome),
           root = Wrapper.unwrapIValue(frame.executionContext.globalObject, Firebug.viewChrome);

Any suggestions/recommendations for these points would be greatly helpful and appreciated!

dhruvaray avatar Jun 14 '14 19:06 dhruvaray

this.jsd.functionHook = { onCall: this.onFunction };

You might to hook onEnterFrame, see this snippet that shows how the profiler does it: https://github.com/firebug/firebug/blob/master/extension/content/firebug/console/profilerEngine.js#L51

Wrapper.unwrapIValue(

Again follow the profiler: https://github.com/firebug/firebug/blob/master/extension/content/firebug/console/profilerEngine.js#L105

All you need should be in frame or frame.script.

Honza

janodvarko avatar Jun 16 '14 13:06 janodvarko

Not directly related, but is support for Firefox 30.0 on the way as well?

Not sure what you mean, Firebug 2 is for Firefox 30 and Firebug 1.12.8 should work with Firefox 30 too.

Honza

janodvarko avatar Jun 16 '14 13:06 janodvarko

@janodvarko my bad, I didn't know that. Thanks for clearing it out! :smile:

hovsater avatar Jun 17 '14 12:06 hovsater

np :-)

janodvarko avatar Jun 17 '14 12:06 janodvarko

@janodvarko : Thanks for the pointers... I did some reading up and have moved the deep-check part to use the JSD2 APIs.

On an unrelated note, web pages using IFRAMES (like jsfiddle, jsbin) are yet giving problems, but I am looking into that.

Internally, I use:

context.browser.addProgressListener(Obj.extend(Http.BaseProgressListener, {...

dhruvaray avatar Jun 22 '14 08:06 dhruvaray

@janodvarko : Just to be clear on the IFRAME part :

The parent - http://jsfiddle.net/icoxfog417/pfxP5/ - and it's composed IFRAME (src @ ) http://jsfiddle.net/icoxfog417/pfxP5/show should have entered twice (for the same Firebug context) in the method below. But that does not seem to happen anymore with the Firebug 2.0+. Yet debugging, but any suggestions would be appreciated!

context.browser.addProgressListener(Obj.extend(Http.BaseProgressListener, {

          onStateChange:function (progress, request, flag, status) {

               if (flag & STATE_IS_REQUEST && flag & STATE_START) {
                                var win = progress.DOMWindow;

dhruvaray avatar Jun 22 '14 14:06 dhruvaray

@KevinSjoberg : New release is now compatible with Firebug 2.0. You can grab the binaries from here : https://github.com/dhruvaray/spa-eye/releases

I have just uploaded to the Mozilla store. So it should go through review soon and become public.

I have been caught up with so many other things that the responses to issues have not been as fast as I would have liked them to be :(

dhruvaray avatar Jun 28 '14 12:06 dhruvaray

@dhruvaray I really appreciate the hard work put in! Thanks a lot. :smile:

hovsater avatar Jun 29 '14 18:06 hovsater

Confirmed - it works great. You can probably close the issue now.

bjmiller avatar Jul 01 '14 13:07 bjmiller

Thanks @KevinSjoberg @bjmiller

dhruvaray avatar Jul 02 '14 02:07 dhruvaray