weather-app icon indicating copy to clipboard operation
weather-app copied to clipboard

Rather than using DOM to access elements, separate components should be created.

Open rajneesh069 opened this issue 1 year ago • 13 comments

Since we are using React.js as our front-end framework hence we should create different components for different UI elements rather than using DOM to access/manipulate them as it makes things confusing as it depicts that those elements are in the static index.html file but in reality they are just being returned inside the main WeatherApp function inside "WeatherApp.jsx". I am attaching relevant screenshots here. Please look into it.

rajneesh069 avatar Dec 31 '23 14:12 rajneesh069

Screenshot from 2023-12-31 19-47-28

rajneesh069 avatar Dec 31 '23 14:12 rajneesh069

I can fix this issue if not yet fixed or assigned to anyone. Thank you!

TejasSathe010 avatar Jan 03 '24 05:01 TejasSathe010

@rajneesh069 I have assigned it to you.

dhruvabhat24 avatar Jan 03 '24 06:01 dhruvabhat24

@rajneesh069 I have assigned it to you.

Okay, I'll work on it. Although I'll need some time to work on it as I am occupied with my own project right now.

rajneesh069 avatar Jan 03 '24 07:01 rajneesh069

Okay take your time

dhruvabhat24 avatar Jan 03 '24 07:01 dhruvabhat24

Hi. The useref() hook is used to access elements right? In my opinion, it would be a great idea to employ that.

Ceejay-777 avatar Jan 04 '24 13:01 Ceejay-777

Hi, good day. Can I work on this? I should be done with it soon.

Ceejay-777 avatar Jan 10 '24 07:01 Ceejay-777

Okay I will assign it to you

dhruvabhat24 avatar Jan 10 '24 10:01 dhruvabhat24

If this issue is still open, i'll work on it. Please assign it to me if still available.

DeeKoders avatar May 23 '24 09:05 DeeKoders

@DeeKoders Sorry for the delay this task is assigned to you and you can work on it

dhruvabhat24 avatar May 28 '24 12:05 dhruvabhat24

@DeeKoders Sorry for the delay this task is assigned to you and you can work on it

on it

DeeKoders avatar Jun 03 '24 08:06 DeeKoders

@dhruvabhat24 The issue seems to be resolved. Can you verify it and close the issue

DeeKoders avatar Jun 03 '24 10:06 DeeKoders

Okay Let me check

dhruvabhat24 avatar Jun 03 '24 10:06 dhruvabhat24