ritajs-v2
ritajs-v2 copied to clipboard
Increase coverage numbers
This is a background task that you can work on whenever you run out of things to do, or need a break from something else. We want to get coverage for every class above ~~90~~95%. Below are the current metrics (in Java, via Eclipse, and in JS via 'yarn test-cov'). Don't worry about anything related to RiScript (visitor.js, etc.) as I will handle these.
in 12 Mar 2021
![螢幕截圖 2021-03-12 下午8 53 27](https://user-images.githubusercontent.com/61215358/110942618-01d3c480-8375-11eb-88b0-ff50289ee251.png)
- a non reachable function
stemAll()
insteam.js
line 844 - some not-used function (e.g functions for print something to console )in
tagger.js
and other files
Hmm, I'm wondering why my numbers are different than yours... Can you try running the command again:
$ npm run coverage
commit d747f3b32c
![Screenshot 2021-03-13 at 2 01 14 AM](https://user-images.githubusercontent.com/737638/110979856-2002ea00-83a0-11eb-8376-5fef3a7bf8e1.png)
Lets also try to get branches and functions up around 95% as well
![螢幕截圖 2021-03-13 下午8 37 39](https://user-images.githubusercontent.com/61215358/111030202-f5666f00-843b-11eb-9bc3-e45f765757e6.png)
![螢幕截圖 2021-03-13 下午8 38 00](https://user-images.githubusercontent.com/61215358/111030212-02835e00-843c-11eb-84c3-012b91321f30.png)
hmm... your node version and commit? I'm on v14.15.5 / 19afca0cf6772
![Screenshot 2021-03-13 at 9 15 16 PM](https://user-images.githubusercontent.com/737638/111031204-4036b580-8441-11eb-9c07-6a1ab8b3f010.png)
@Real-John-Cheung pls revisit -- we need to figure out why we are not getting the same numbers
here is my result on current head d2071ef
It seems that for most files there is no branch, which is a bit weird
I am running
npm run coverage
for the coverage
![image](https://user-images.githubusercontent.com/737638/112144897-a6c38c80-8c14-11eb-98b2-1f668791731c.png)
@Real-John-Cheung pls add a current snapshot of coverage numbers as above
As for 3/5/2021
no rush, but eventually lets get everything over 90%