ritajs-v2 icon indicating copy to clipboard operation
ritajs-v2 copied to clipboard

Increase coverage numbers

Open dhowe opened this issue 3 years ago • 9 comments

This is a background task that you can work on whenever you run out of things to do, or need a break from something else. We want to get coverage for every class above ~~90~~95%. Below are the current metrics (in Java, via Eclipse, and in JS via 'yarn test-cov'). Don't worry about anything related to RiScript (visitor.js, etc.) as I will handle these.

image

image

dhowe avatar Dec 12 '20 09:12 dhowe

in 12 Mar 2021

螢幕截圖 2021-03-12 下午8 53 27
  • a non reachable function stemAll() in steam.js line 844
  • some not-used function (e.g functions for print something to console )in tagger.js and other files

Real-John-Cheung avatar Mar 12 '21 12:03 Real-John-Cheung

Hmm, I'm wondering why my numbers are different than yours... Can you try running the command again:

$ npm run coverage

commit d747f3b32c

Screenshot 2021-03-13 at 2 01 14 AM

Lets also try to get branches and functions up around 95% as well

dhowe avatar Mar 12 '21 17:03 dhowe

螢幕截圖 2021-03-13 下午8 37 39 螢幕截圖 2021-03-13 下午8 38 00 That's the result of the current master branch for me...

Real-John-Cheung avatar Mar 13 '21 12:03 Real-John-Cheung

hmm... your node version and commit? I'm on v14.15.5 / 19afca0cf6772

Screenshot 2021-03-13 at 9 15 16 PM

dhowe avatar Mar 13 '21 13:03 dhowe

@Real-John-Cheung pls revisit -- we need to figure out why we are not getting the same numbers

dhowe avatar Mar 23 '21 09:03 dhowe

here is my result on current head d2071ef 螢幕截圖 2021-03-23 下午8 00 29 It seems that for most files there is no branch, which is a bit weird I am running npm run coverage for the coverage

Real-John-Cheung avatar Mar 23 '21 12:03 Real-John-Cheung

image

dhowe avatar Mar 23 '21 12:03 dhowe

@Real-John-Cheung pls add a current snapshot of coverage numbers as above

dhowe avatar May 03 '21 06:05 dhowe

As for 3/5/2021

image

no rush, but eventually lets get everything over 90%

Real-John-Cheung avatar May 03 '21 13:05 Real-John-Cheung