AdNauseam icon indicating copy to clipboard operation
AdNauseam copied to clipboard

Detect text-based ads on Youtube

Open kevinsmia1939 opened this issue 8 years ago • 21 comments

Describe the issue

AdNauseam don't detect ads on youtube. But the ads are block. Disable AdNauseam display ads, activate AdNauseam block ads as expect. But it will show "No Ads collected on this page (showing recent)" Other websites work properly, only noticed this on youtube.

One or more specific URLs where the issue occurs

https://www.youtube.com/

Screenshot in which the issue can be seen

Steps for anyone to reproduce the issue

(Please be as detailed as possible)

Your settings

  • OS/version: Manjaro KDE 17.1.8 stable
  • Browser/version: Firefox 59.0.2 (64-bit)
  • AdNauseam version: AdNauseam v3.5.101 uBlock Originv1.14.14
  • Other extensions you have installed: uGet integration, Trackmenot, Stylish, KeepassXC-Browser.

Your location/country

(If the issue is website specific, knowing your approximate location will help us to reproduce it) Thailand.

kevinsmia1939 avatar Apr 22 '18 09:04 kevinsmia1939

Currently don't collected video ads, so in such cases, we block them only.

dhowe avatar Apr 22 '18 19:04 dhowe

Did you mean ads that pop inside the video or also besides the video.

What I mean by beside the video is this https://imgur.com/3YQSBxH

Just to be clear ads inside and beside video are both block, just wondering if "beside video ads" are collected.

kevinsmia1939 avatar Apr 22 '18 20:04 kevinsmia1939

No video ads are collected at all

dhowe avatar Apr 23 '18 12:04 dhowe

If it is by design, what is the reasoning for this choice of not collecting video ads? Just curious.

Capaverde avatar Jul 04 '18 11:07 Capaverde

Would love for it to collect ads on videos if possible. 75% of my web usage is Youtube

JazRav avatar Aug 14 '18 22:08 JazRav

I would like to add to this request and I would like to support YouTubers too when I block their ads. I watch a lot of youtube as well. Is this technically possible? If needed, I can contribute too. Point me to the relevant direction, please.

WoodpeckerBaby avatar Dec 19 '19 06:12 WoodpeckerBaby

@cqx931 we should be able to block ads beside videos (see below) on youtube pages, yes?

image

dhowe avatar Dec 19 '19 09:12 dhowe

@dhowe For me, all video sites including YouTube works. The static ads on the side, preroll ads, in-frame ads (e.g. when you pause a video) and animated ads are all blocked. However, none of them are "Detected" or "Clicked", which I hope AdNauseam can.

WoodpeckerBaby avatar Dec 19 '19 21:12 WoodpeckerBaby

@WoodpeckerBaby Could you please provide more screenshots as well as links when you see each kind of ads? I don't think we can do much with video ads. But if they exist in a certain format with images and text, we can create youtube specific parsers.

Currently I can only find the ad that @dhowe sees on youtube home page, which adnauseam currently only hides but not collects.

cqx931 avatar Dec 19 '19 22:12 cqx931

Another example of a similar ad format that promotes youtube channels. Found on the side.

image

cqx931 avatar Dec 19 '19 22:12 cqx931

As Youtube represents a vast ad market, I think we should indeed create a custom parser for such ads (not mid-video ads, but those on the side) so that we can can successfully collect them.

dhowe avatar Dec 20 '19 04:12 dhowe

Added a youtube parser here: https://github.com/dhowe/AdNauseam/pull/1601

Screen Shot 2019-12-20 at 12 08 58 PM

cqx931 avatar Dec 20 '19 17:12 cqx931

@mneunomne please check this on current youtube

dhowe avatar May 23 '22 12:05 dhowe

@dhowe I have worked on it for a bit and its quite tricky. As it currently is, the ads are not being rendered so we can't collect them. I try to come up with the combination of exception so they can be rendered, and then we can collect&hide, but then the Video ads start showing up... I will keep trying but in the case of youtube is hard to separate Make the banner ads get rendered AND hide the video ads at the same time.

mneunomne avatar Jun 19 '22 18:06 mneunomne

Okay, after a lot of tries seems that it is working, needs more testing to see if some ads wont go through after this.

Screenshot 2022-06-20 at 03 51 58

mneunomne avatar Jun 20 '22 01:06 mneunomne

So , now YouTube ads will be clicked in the background?

venkat2305 avatar Jun 21 '22 06:06 venkat2305

No ads on YouTube are getting collected.

chirag127 avatar Jul 10 '22 06:07 chirag127

Some youtube ads now are being collected yes. But it will not work on everycase, I have implemented only for the case of youtube banner ads on the side:

Ads that are displayed between videos are not possible for us to collect/click from my understanding.

mneunomne avatar Jul 11 '22 09:07 mneunomne

Seems like it stoped collecting again... The tricky thing about this parser is that the div structure of the big websites like facebook/youtube/google changes quite often, I'll try to adapt it yet again.

Ideally these specific parsers should somehow also be able to be in the filters/adnauseam.txt so that this could be updated faster.

mneunomne avatar Aug 03 '22 09:08 mneunomne

Ideally these specific parsers should somehow also be able to be in the filters/adnauseam.txt so that this could be updated faster.

Indeed, or a similar file that can be updated without a release -- would be a great feature, but not easy, and potentially insecure

dhowe avatar Aug 03 '22 16:08 dhowe

Youtube ads are being collected, not as many as we probably can, but still are being collected.

Screenshot 2022-10-18 at 05 21 32

I'll move this issue from milestone 3.15 to ongoing.

mneunomne avatar Oct 18 '22 03:10 mneunomne