multi-semantic-release icon indicating copy to clipboard operation
multi-semantic-release copied to clipboard

Can't find packages when `nohoist` is configured

Open StevenLangbroek opened this issue 5 years ago • 4 comments

Hey folks! We're running into a little issue:

We've configured nohoist to deal with some Typescript malarkey. In our root package.json, workspaces looks like this:

  "workspaces": {
    "packages": [
      "packages/core",
      "packages/react"
    ],
    "nohoist": [
      "**/react-native",
      "**/react-native/**"
    ]
  },

This leads to this error:

[multi-semantic-release]: TypeError: package.json: workspaces: Must be non-empty array of string

Should this be supported? We can work around this for now by feeding it the path of projects manually by using the programmatic API, but if you think it's something that should work I'd gladly submit a fix.

Thanks ❤️

StevenLangbroek avatar Jul 16 '20 04:07 StevenLangbroek

Ok so the fix seems pretty straightforward and I'd gladly contribute it back if you're interested in fixing this.

StevenLangbroek avatar Jul 16 '20 06:07 StevenLangbroek

@StevenLangbroek, any feedback, ideas or improvements are appreciated. Feel free to open PR as soon as you wish.

antongolub avatar Jul 16 '20 06:07 antongolub

:tada: This issue has been resolved in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dhoulb avatar Jul 16 '20 07:07 dhoulb

Misclicked when I closed the issue.

antongolub avatar Jul 16 '20 07:07 antongolub