boxable icon indicating copy to clipboard operation
boxable copied to clipboard

Issue and PR management in order to create a new release

Open johnmanko opened this issue 3 years ago • 9 comments

Just looking to get @dhorions's attention here. We really need some changes on this project. :)

PR #247 (fix: #233, #236, #237, #239, #241, #246) addresses the following issues and PRs, and should be merged:

  • #233 (PR)
  • #236 (ISS)
  • #237 (PR)
  • #239 (PR)
  • #241 (ISS)
  • #246 (ISS)

PR #224 (Bugfix216) should be merged, as it fixes #216 (> is replaced with > in the Inner Table with boxable)

PR #234 ( Issue #120: Add support for setting hyperlink URL on a Cell) fixes issue #120

PR #106 (Add license information to the pom.xml) and Issue #231 (Boxable jar may not be Apache 2 licensed) need reconciliation, as they both deal with Apache 2.0 licensing.

PR #151 (Table class overhauled, main package cleaned up.) looks like a great candidate.

johnmanko avatar Dec 15 '21 03:12 johnmanko

@dhorions Would you like to transfer this project to me so I can start merging pull requests? Also, I'd like to do a maven release.

johnmanko avatar Apr 22 '22 03:04 johnmanko

Hello @johnmanko,

You are right , I haven't been giving this project the attention it deserves . Can we talk about this on a call? What works for you and how can I reach you best?

dhorions avatar Apr 22 '22 06:04 dhorions

@dhorions I don't see a way to communicate privately through Github, so I guess I'll have to create a temporary email address to exchange numbers. I'll do that this weekend and update this issue with that info.

Thanks for getting back to me.

johnmanko avatar Apr 22 '22 15:04 johnmanko

You can also send me a pm on twitter https://twitter.com/indiedries @johnmanko

dhorions avatar Apr 22 '22 15:04 dhorions

@dhorions I'll have to create a twitter account. haha.

johnmanko avatar Apr 22 '22 15:04 johnmanko

@johnmanko email me at ****

dhorions avatar Apr 26 '22 20:04 dhorions

@dhorions email sent.

johnmanko avatar Apr 27 '22 15:04 johnmanko

PR https://github.com/dhorions/boxable/pull/247 fixed with https://github.com/dhorions/boxable/commit/943e45363d1f19dc16e603cf80ada27799600546

johnmanko avatar Jun 05 '22 15:06 johnmanko

I'd also like to review https://github.com/dhorions/boxable/issues/98

The more dependencies that can be removed, the better. And perhaps changing pdfbox/etc to provided will provide more flexibility to users.

johnmanko avatar Jun 06 '22 15:06 johnmanko