h264-reader
h264-reader copied to clipboard
Published
20 hours ago •
dholroyd
dholroyd
Bounds checks for many fields
Turns out to be more complicated than I expected due to the need to refer to a table of values from the spec when calculating the max value for max_dec_frame_buffering.
log2_max_mv_length_horizontal and log2_max_mv_length_vertical are not checked to the [0, 15] limits in the most recent spec because older specs said the restriction was [0, 16] and real world test data appears to use the value 16.
Other changes included,
- Levels 6, 6.1 and 6.2, because the spec doc I'm referring to for "Table A-1 – Level limits" has these levels now
- some rewiring to thread SPS/PPS info through to code that needs them to perform field validations
Fixes #55 and #58
Bencher
| Report | Fri, March 1, 2024 at 07:28:22 UTC |
| Project | h264-reader |
| Branch | 66/merge |
| Testbed | ubuntu-22.04 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | Instructions | Instructions Results instructions | L1 Accesses | L1 Accesses Results accesses | L2 Accesses | L2 Accesses Results accesses | RAM Accesses | RAM Accesses Results accesses | Total Accesses | Total Accesses Results total-accesses |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24f... | ➖ (view plot) | 16653199.000 | ➖ (view plot) | 8205418.000 | ➖ (view plot) | 10769774.000 | ➖ (view plot) | 16841.000 | ➖ (view plot) | 165692.000 | ➖ (view plot) | 10952307.000 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bencher
| Report | Fri, March 1, 2024 at 18:56:06 UTC |
| Project | h264-reader |
| Branch | 66/merge |
| Testbed | localhost |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Lower Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | L1 Accesses | L1 Accesses Results accesses | L2 Accesses | L2 Accesses Results accesses | RAM Accesses | RAM Accesses Results accesses | Total Accesses | Total Accesses Results total-accesses |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24f... | ✅ (view plot) | 16648266.000 (+0.04%) | 14976912.000 (89.96%) | ➖ (view plot) | 8205445.000 | ➖ (view plot) | 10771081.000 | ➖ (view plot) | 15558.000 | ➖ (view plot) | 165697.000 | ➖ (view plot) | 10952336.000 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help