Daniel Holmgren comments

Results 141 comments of


                                            Daniel Holmgren

Record references in lexicon typed as unknown

important to note that `unknown` comes with one additional requirement that the contained object has a `$type` key on it an `unknown` in lexicon is the same thing as an...

Record references in lexicon typed as unknown

yup that sounds accurate 👍

convert punycode domain handles to ASCII

Hmm these methods are only used on parameters/inputs into the PDS 🤔 Since the handles are normalized & indexed as such, they'll be returned as ASCII in views. And this...

test (api, common, common-web): add further tests

ah some linting errors. would you mind fixing? think you should be able to fix with `yarn verify:fix`

test (api, common, common-web): add further tests

lost track of this one - thanks for the fixes! merging now 👍

Link card CORS policy block

Yup yup we need to proxy these

@atproto/api docs are missing when published on NPM

Looks like this one resolved itself fortunately

Parse URLs after sentence dot corectly

bump @pfrazee

Creating records in some collections make them undeletable.

What error do you get? And what rkey is it at?

Creating records in some collections make them undeletable.

You'd need to do `deleteRecord` with the TID that it was given