Daniel Leong

Results 72 comments of Daniel Leong

Hmm. I think the behavior you described is what I _actually_ want in that ticket. Weirdly, though, Eclim _does_ take me to the implementation, generally, with `:JavaSearch -x declarations`. I...

I actually looked into the code for this earlier today and discovered this comment in the `:JavaSearch` command: ``` java // jdt search doesn't support implementors for method searches, so...

Okay, I found a place in some code I have that replicates this issue. The problem is that even though I have two classes that implement the method—which Eclipse successfully...

@ahnick I just submitted a PR that I think will do what you want. I've mapped it like this: ``` vim nmap gd :JavaSearch -x implementors -s workspace ``` Feel...

You're going to have to provide a minimal example that demonstrates that. @ervandew's merged code works for everyone else's cases. See discussion here: https://github.com/ervandew/eclim/pull/358

The code and the feature are for the `-x implementors` flag, so it sounds like there's nothing wrong related to this ticket. I assume you meant `-p MyClass.MyMethod` in your...

I'm not sure what is causing your difficulty, but I think there is some misunderstanding. I'm not sure where you see that a different command is used. `JavaSearchContext` is a...

> JavaSearchContext is not a convenience for JavaSearch Yes, it is: ``` vim if !exists(":JavaSearch") command -buffer -nargs=* \ -complete=customlist,eclim#java#search#CommandCompleteSearch \ JavaSearch :call eclim#java#search#SearchAndDisplay('java_search', '') endif if !exists(":JavaSearchContext") command -buffer...

> So JavaSearch is the same with or without -p No, it's not. You're misreading that. If you do `:JavaSearch hello` then it will interpret that as `:JavaSearch -p hello`....

I think what you want is just `:JavaSearch -x implementors`. Based on the vim declaration of `:JavaSearchContext`, (using -nargs=?) it should only accept at most the optional string pattern. With...