cord icon indicating copy to clipboard operation
cord copied to clipboard

[C4GT] Network-Score: Add tests for 'InvalidEntryOrRatingType'

Open vatsa287 opened this issue 1 year ago • 2 comments

Description

Subtask under : https://github.com/cord-network/community/issues/7

New testcase can be tested under cargo test -p pallet-network-score after adding it in the code.

Goals

  • [ ] Add tests for InvalidEntryOrRatingType for pallet/network-score

Expected Outcome

  • [ ] Test should assert for InvalidEntryOrRatingType being returned properly in all the possible calls.
  • [ ] If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same. Ex: In pallets/network-membership check method test_duplicate_member_request which validates error code MembershipAlreadyAcquired

Mockups / Wireframes

NA


Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Medium]

Category

[Test]

Sub Category

[Beginner friendly]

vatsa287 avatar Feb 05 '24 17:02 vatsa287

Hey @vatsa287 sir I would love to work on this project.. Please assign this to me if possible

Jhanvi528 avatar Mar 21 '24 18:03 Jhanvi528

Hello @vatsa287 @amarts, I want to work on this project Can you assign this issue to me?

PayalKumari10 avatar May 02 '24 06:05 PayalKumari10

@vatsa287 can i work on this issue?

prathmesh703 avatar Feb 27 '25 03:02 prathmesh703

@vatsa287 should i work on this issue?

Vaibhavsahu2810 avatar Mar 14 '25 08:03 Vaibhavsahu2810

Hi @amarts,

I would like to contribute to adding tests for the InvalidEntryOrRatingType error in the pallet/network-score for the CORD project. The objective is to ensure that the InvalidEntryOrRatingType error is returned correctly in all the relevant functions.

I will refer to other existing test cases, such as the test_duplicate_member_request in pallet/network-membership, to implement the necessary validation for the InvalidEntryOrRatingType error. I will ensure that all functions that handle this error code are properly validated, whether as a single test case or multiple ones.

Please assign me this issue, and I’ll get started on it right away.

Thank you,

rahulbamnuya avatar Apr 20 '25 23:04 rahulbamnuya

We are moving away from the 'network-score' pallet described here to something newer soon.

Hence, closing this issue.

Refer to https://github.com/dhiway/cord/blob/develop/docs/cord-features.md to get more idea about what features you can contribute on.

amarts avatar Apr 21 '25 01:04 amarts