cord icon indicating copy to clipboard operation
cord copied to clipboard

[C4GT] Network-Score: Add tests for 'UnauthorizedOperation'

Open vatsa287 opened this issue 1 year ago • 4 comments

Description

Subtask under : https://github.com/cord-network/community/issues/7

New testcase can be tested under cargo test -p pallet-network-score after adding it in the code.

Goals

  • [ ] Add tests for UnauthorizedOperation for pallet/network-score

Expected Outcome

  • [ ] Test should assert for UnauthorizedOperation being returned properly in all the possible calls.
  • [ ] If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same. Ex: In pallets/network-membership check method test_duplicate_member_request which validates error code MembershipAlreadyAcquired

Mockups / Wireframes

NA


Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Low]

Category

[Test]

Sub Category

[Beginner friendly]

vatsa287 avatar Feb 05 '24 17:02 vatsa287

Hey @amarts I would like to work on this issue ! Kindly assign it to me if possible.

hardik-pratap-singh avatar Apr 02 '24 10:04 hardik-pratap-singh

@hardik-pratap-singh Look at this issue.

vatsa287 avatar Apr 02 '24 10:04 vatsa287

Hey @amarts! I'm looking forward to contribute towards solving this issue. Could you please assign it to me? I already have experience with Rust and Blockchain and I believe I can deliver the same to the community in no time! Looking forward for a positive response from your end.

ayush572 avatar Aug 06 '24 07:08 ayush572

Hello @ayush572 Do you need any assistance with the issue or any progress you might want to share? Thanks.

VedantKhairnar avatar Aug 26 '24 11:08 VedantKhairnar

Hello,@vatsa287 should i work on it

Vaibhavsahu2810 avatar Dec 25 '24 07:12 Vaibhavsahu2810

please assign me this issue @vatsa287

HasanZaigam avatar Jan 02 '25 18:01 HasanZaigam

I have made changes and tried to add the desired test case, and here is the PR - https://github.com/dhiway/cord/pull/557

@vatsa287 Bro, please go through it and let me know what changes need to be made to fix the test and help me tackle this issue successfully. I need your help with this.....

HasanZaigam avatar Jan 02 '25 18:01 HasanZaigam

We are moving away from the 'network-score' pallet described here to something newer soon.

Hence, closing this issue.

Refer to https://github.com/dhiway/cord/blob/develop/docs/cord-features.md to get more idea about what features you can contribute on.

amarts avatar Apr 21 '25 01:04 amarts