ui
ui copied to clipboard
feat: header bar for global shell [DHIS2-15635]
Implements DHIS2-15635
WIP -- More changes may need to follow
Description
- [x] When in a React Router context, uses client-side routes to apps
- [x] Fixes App Menu design to be close-able when clicking on an
iframe - [x] Merge in changes from RTL
- [ ] Redesign "App/Instance" info in profile menu
- [ ] Handle PWA update info
- [ ] Get client app info and add global shell info
Known issues
- [ ] issue
Checklist
- [ ] API docs are generated
- [ ] Tests were added
- [ ] Storybook demos were added
Screenshots
supporting text
1 failed test on run #3232 ↗︎
Details:
| fix(header-bar): use layer method to close menu on outside click | |||
| Project: ui | Commit: b9667b309c |
||
| Status: Failed | Duration: 06:53 💡 | ||
| Started: Feb 15, 2024 3:47 PM | Ended: Feb 15, 2024 3:54 PM | ||
components/header-bar/src/features/the_headerbar_contains_a_menu_to_all_apps.feature • 1 failed test • e2e
| Test | Artifacts | |
|---|---|---|
| The HeaderBar contains a menu to all apps > The app menu closes when the user clicks outside |
Screenshots
|
|
Review all test suite changes for PR #1454 ↗︎
🚀 Deployed on https://pr-1454--dhis2-ui.netlify.app
Quality Gate failed
Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
Quality Gate failed
Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE