dhis2-core icon indicating copy to clipboard operation
dhis2-core copied to clipboard

feat: Support MinIO

Open tonsV2 opened this issue 1 year ago • 4 comments

https://dhis2.atlassian.net/browse/DEVOPS-273

tonsV2 avatar Aug 09 '23 07:08 tonsV2

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 67.17%. Comparing base (e4b258e) to head (f36642b). Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14869       +/-   ##
=============================================
+ Coverage     50.31%   67.17%   +16.86%     
- Complexity    24212    32253     +8041     
=============================================
  Files          3560     3560               
  Lines        132193   132202        +9     
  Branches      15336    15338        +2     
=============================================
+ Hits          66511    88811    +22300     
+ Misses        59464    36189    -23275     
- Partials       6218     7202      +984     
Flag Coverage Δ
integration 50.16% <41.17%> (?)
integration-h2 33.87% <41.17%> (+<0.01%) :arrow_up:
unit 30.44% <5.88%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../org/hisp/dhis/external/conf/ConfigurationKey.java 100.00% <100.00%> (ø)
...hisp/dhis/appmanager/JCloudsAppStorageService.java 53.24% <37.50%> (-0.06%) :arrow_down:
.../fileresource/JCloudsFileResourceContentStore.java 56.54% <37.50%> (+0.92%) :arrow_up:

... and 1280 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4b258e...f36642b. Read the comment docs.

codecov[bot] avatar Aug 09 '23 07:08 codecov[bot]

@larshelge Why are you closing this one? Supporting MinIO could be very usable for several use cases :-)

tonsV2 avatar Feb 05 '24 04:02 tonsV2

Created issue in core project https://dhis2.atlassian.net/browse/DHIS2-17174 Closing this PR in favor of https://github.com/dhis2/dhis2-core/pull/17014 which links changes to above issue.

teleivo avatar Apr 02 '24 11:04 teleivo