dhis2-core icon indicating copy to clipboard operation
dhis2-core copied to clipboard

fix : Fix tracker data view query [DHIS2-12249]

Open zubaira opened this issue 3 years ago • 4 comments

zubaira avatar Aug 04 '22 12:08 zubaira

Codecov Report

Merging #11400 (7cfd0f5) into master (011223a) will decrease coverage by 0.00%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11400      +/-   ##
============================================
- Coverage     63.13%   63.13%   -0.01%     
  Complexity    27308    27308              
============================================
  Files          3176     3176              
  Lines        112625   112625              
  Branches      13311    13311              
============================================
- Hits          71105    71103       -2     
  Misses        35364    35364              
- Partials       6156     6158       +2     
Flag Coverage Δ
integration 45.47% <ø> (-0.01%) :arrow_down:
integration-h2 32.92% <ø> (-0.01%) :arrow_down:
unit 28.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/src/main/java/org/hisp/dhis/program/Program.java 85.29% <0.00%> (-0.99%) :arrow_down:
...ava/org/hisp/dhis/system/util/ReflectionUtils.java 49.39% <0.00%> (-0.61%) :arrow_down:
.../engine/DefaultProgramRuleEntityMapperService.java 76.51% <0.00%> (+0.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2181c16...7cfd0f5. Read the comment docs.

codecov[bot] avatar Aug 04 '22 12:08 codecov[bot]

Is it okay to change an existing, released Flyway migration? I assume this would crash for all implementations with a checksum mismatch, without enabling Flyway repair, which we have not told any implementations to do?

larshelge avatar Aug 04 '22 20:08 larshelge

Is it okay to change an existing, released Flyway migration? I assume this would crash for all implementations with a checksum mismatch, without enabling Flyway repair, which we have not told any implementations to do?

That's right @larshelge For exactly this reason I wanted to raise this as draft PR and keep looking for a way forward. But accidentally this was raised as review PR.

zubaira avatar Aug 04 '22 20:08 zubaira

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 23 '22 18:08 sonarqubecloud[bot]