dhis2-android-dashboard icon indicating copy to clipboard operation
dhis2-android-dashboard copied to clipboard

Polish UI layout issues.

Open arazabishov opened this issue 10 years ago • 9 comments

To fix: jagged three dot menu buttons, alignment issues, wrong paddings, wrong text colours and sizes, wrong icon colour and sizes.

Update Currently, application is designed in material-ish way. The goal of this task is to re-design app in order to conform to google's design guidelines including fonts, dimensions, key-lines, etc.

arazabishov avatar Jul 29 '15 06:07 arazabishov

@ArazAbishov I would like to work on this issue. Can you tell me which screen are we having this issue in general and do we have any design based on which we should make this?

akshayjain007 avatar Mar 04 '16 13:03 akshayjain007

@ArazAbishov I would love to work on this. Can you please elaborate on the details

laavanyebahl avatar Mar 05 '16 23:03 laavanyebahl

@ArazAbishov : I would like to work on this. Could you tell which layouts need to be updated, which colors and icons are wrong?

chinmay1994 avatar Mar 09 '16 13:03 chinmay1994

Hello @ArazAbishov as we per your requirements i have applied some changes on Ui. Please review and share your views:

  1. Login page: screenshot_2016-03-10-13-39-02

  2. Removed extra blank space, and more readable text style. screenshot_2016-03-12-23-59-38

  3. Settings Page : screenshot_2016-03-13-00-00-11

  4. Readable Account Details screenshot_2016-03-12-23-59-54

  5. Modified progress to make more understandable. More gap and modified color screenshot_2016-03-13-00-00-40

  6. Clear instructions: screenshot_2016-03-13-00-00-32

code-crusher avatar Mar 12 '16 19:03 code-crusher

@Vatsal-Bajpai Hi Vatsal, great work! Could you please submit pull-request?

arazabishov avatar Mar 19 '16 15:03 arazabishov

@ArazAbishov sure. I'll just submit it :)

code-crusher avatar Mar 19 '16 15:03 code-crusher

@Vatsal-Bajpai Thank you, I will review the code and will come back to you with more comments.

arazabishov avatar Mar 19 '16 15:03 arazabishov

Hello @ArazAbishov, I have made the following changes in the UI as per the requirements and submitted the pull request #39. Kindly review them.

Thank you.

Changelog:

  • Removed the library used for the horizontal progress bar.
  • Bug fixes in BaseAdapter.
  • Swipe to refresh implemented along with workarounds for the bugs in the layout.
  • User Account Fragment UI slightly changed.
  • Removed some extra layouts from XML to improve performance.
  • Added RecyclerView Animator.
  • Fixed margins and padding in some places.

ezgif com-video-to-gif

ezgif com-video-to-gif 1

ezgif com-video-to-gif 2

prashantsolanki3 avatar Mar 22 '16 21:03 prashantsolanki3

Hi! Due to a lack of activity on this issue over time (7.776*10^9 ms and counting, to be precise) it seems to be stale. If there is no further progress on it, it will be closed automatically.

If this is still relevant, maybe there is something you can do to move it forward? For example provide further information in a comment, or supply a PR? Any activity on this issue will keep it open. Thanks! 🤖

stale[bot] avatar Apr 04 '19 04:04 stale[bot]