dashboard-app icon indicating copy to clipboard operation
dashboard-app copied to clipboard

Published 20 hours ago • verified publisher icon dhis2

fix: disable-network-checks using patch-package

Open jenniferarnesen opened this issue 2 years ago • 3 comments

This PR is an alternative to https://github.com/dhis2/dashboard-app/pull/2144. It shouldn't be necessary to do anything with the OfflineTooltip, since that component also uses the useOnlineStatus hook. This will also ensure that any other dependencies (i.e. from d2-ui, analytics, etc) that depend on online status will also get online: true.

jenniferarnesen avatar Oct 31 '22 11:10 jenniferarnesen

🚀 Deployed on https://pr-2145--dhis2-dashboard.netlify.app

dhis2-bot avatar Oct 31 '22 11:10 dhis2-bot


Test summary

59 • 0 • 0 • 0

Run details
Project dashboards-app
Status Passed
Commit e769bf8c49
Started Nov 10, 2022 4:36 PM
Ended Nov 10, 2022 4:43 PM
Duration 06:40 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Oct 31 '22 11:10 cypress[bot]

Looks great! This is a textual approval to avoid this getting merged accidentally 😁 ✅

I tested this pretty extensively both in a dev environment and a production build deployed on a local instance with the internet entirely disconnected.

KaiVandivier avatar Nov 02 '22 16:11 KaiVandivier

This has been merged separately into a custom patch. Keeping the branch incase it is needed in the future.
https://dhis2.atlassian.net/browse/LIBS-315

jenniferarnesen avatar Dec 20 '22 16:12 jenniferarnesen