Dave Hirschfeld
Dave Hirschfeld
Thanks for taking the time to triage this issue!
It's curious because the `TIMESTAMP` class does have a class-level `impl` attribute: ```python impl = sqlalchemy.types.DateTime ``` https://github.com/databricks/databricks-sql-python/blob/50489346440cdf9e547b597254643ee4ceb28c19/src/databricks/sqlalchemy/_types.py#L147
...and seems to be following the recommended recipe to augment existing types: https://docs.sqlalchemy.org/en/20/core/custom_types.html#augmenting-existing-types
It seems that `sqlqcodegen` is trying to directly instantiate a `TypeDecorator` class (as that's the correct super-class of `TIMESTAMP`) but that will never work as it's not designed to be...
...so I think perhaps the issue lies with a too-strict exception clause here. In the specific instance that the `coltype` is a subclass of `TypeDecorator` the call to `coltype.adapt(supercls)` will...
If you wanted to be a bit more defensive you could instead do: ```python try: new_coltype = coltype.adapt(supercls) except TypeError: # If the adaptation fails, don't try again break except...
***xref:*** - https://github.com/dagster-io/dagster/discussions/18877
Hello, happy New Year! I'm just circling back to check if there was any discussion of this issue on the community call? I'm currently wanting to specify both the `azurestorageaccountname`...
Thanks for the update and the link @nilekhc - I'll follow that PR!
Not a high priority for me as it's a build image I'm creating and I have `mamba` available in it (pulled in by `boa`). That won't always be the case...