py-openaq icon indicating copy to clipboard operation
py-openaq copied to clipboard

Published 20 hours ago • verified publisher icon dhhagan

Add a function to help with recursion

Open dhhagan opened this issue 8 years ago • 5 comments

make it easier to recursively grab all data if there is more than 1 page..

dhhagan avatar Dec 21 '16 19:12 dhhagan

I would like to solve this issue.

biggydbs avatar Oct 04 '17 08:10 biggydbs

@biggydbs Awesome! Let me know if you need any help or have any questions.

dhhagan avatar Oct 04 '17 13:10 dhhagan

Yes, I tried to run all the tests, but some failed (tests.openaq_test.SetupTestCase -> test_pandasize)

biggydbs avatar Oct 04 '17 17:10 biggydbs

That's associated with the pandasize decorator that converts the output to a Pandas DataFrame. The solution should probably be able to deal with both (or I can change the decorator).

dhhagan avatar Oct 05 '17 00:10 dhhagan

Hey @biggydbs I just fixed some issues associated with the pandasize decorator; apparently some breaking changes were made to the OpenAQ API that I wasn't aware of (the API calls started failing when keyword arguments were sent that weren't allowed, whereas previously they were silently dropped). I will be merging those changes into master later today (currently are on branch dev-pc); I would love for you to merge in your changes if that was the only issue!

dhhagan avatar Jan 24 '18 10:01 dhhagan