dhewm3 icon indicating copy to clipboard operation
dhewm3 copied to clipboard

Resolve issues found by static analysis (PVS)

Open demoth opened this issue 6 years ago • 3 comments

Hi Guys

I have run static analysis tool over the code of dhewm3 and found some suspicious places. I hope this could help to find the real bugs. The list is not short and probably should be addressed in batches.

Attaching the report. https://docs.google.com/spreadsheets/d/1cTJH3DNwhfsetZt-pTLb7nDr1SbHEcY8X377En9xBpc/edit#gid=170025750

demoth avatar Jul 19 '19 22:07 demoth

Thanks a lot!

BTW, can you also run it on the Dentonmod branch of dhewm3-sdk? https://github.com/dhewm/dhewm3-sdk/tree/dentonmod It seems to have some crashes that don't happen with the vanilla game (and are not always easy to reproduce), so maybe we're lucky and PVS finds the issues ;)

DanielGibson avatar Jul 19 '19 23:07 DanielGibson

@DanielGibson done! https://github.com/dhewm/dhewm3-sdk/issues/11

demoth avatar Jul 20 '19 20:07 demoth

Awesome, thanks!

DanielGibson avatar Jul 21 '19 01:07 DanielGibson