serverless-offline
serverless-offline copied to clipboard
dherault
fix: responses without default key
Description
This pull request introduces fixes for two issues in the serverless-offline repository: Issue #1705 & Issue #1680 : Resolved a TypeError encountered when destructuring properties from an undefined 'chosenResponse' object in HttpServer.js.
Motivation and Context
Fixing Issue #1705 & #1680 enhances the response handling mechanism and also resolves a critical bug that hinders the normal functionality.
How Has This Been Tested?
Tests were conducted by replicating the scenarios described in the issues. Additional e2e tests were added to cover the new scenarios and ensure no regressions in other parts of the code.
@dnalborczyk Do you have some time to check this? It would simplify my codebase, because now I need to add everywhere default response. Also I attached 2 issues that are related to this PR.
@dnalborczyk Do you have some time to check this? It would simplify my codebase, because now I need to add everywhere default response. Also I attached 2 issues that are related to this PR.
thank you for the PR @DorianMazur ! I'll have a look in the next coming days. hang tight.
@dherault @dnalborczyk I noticed that this package has pull requests that have been pending for long time, including this one which has been waiting for 4 months. If you are seeking for additional maintainers to help manage the project, I would be happy to assist.
That's great! We are indeed looking for maintainers. Please send me an email. You'll find it on my personal website on my GitHub profile.
