semantic-graphql icon indicating copy to clipboard operation
semantic-graphql copied to clipboard

Support domainIncludes and rangeIncludes

Open steffansluis opened this issue 7 years ago • 3 comments

Hi!

A couple of things: really like the library! I also saw you are on vacation until 2018 (enjoy!), so no expectations of urgency here. So I've been using you're library to build a GraphQL API based on an ontology, while using your aquest repo as a guideline. As part of my ontology I would like to extend some schema.org classes, but I ran into a problem there. I was able to include their ontology, but it uses schema:domainIncludes and schema:rangeIncludes to indicate relationships between classes. I did some work on Google and found a discussion about the subject here, which seems to indicate that the Includes version is preferable, although I imagine supported both should be easy enough as well. Any thoughts on the matter? Would be happy to help out with a PR.

steffansluis avatar Nov 27 '17 14:11 steffansluis

hey @steffansluis did you could use this library to work with schema.org? I am playing with some alternatives to work with schema.org on graphql.

xmnlab avatar Mar 28 '19 14:03 xmnlab

Yes this lib can work with the schema.org ontology!

dherault avatar Mar 29 '19 14:03 dherault

@dherault rdfs:domain/range are monomorphic, i.e. should take only one value. Eg your use of multiple rdfs:domain at https://github.com/dherault/aquest/blob/master/ontology/_shared.ttl#L13 and L19 is incorrect.

schema:domain/rangeIncludes are polymorphic.

Cheers!

VladimirAlexiev avatar Aug 21 '19 09:08 VladimirAlexiev