fastexcel icon indicating copy to clipboard operation
fastexcel copied to clipboard

Proposal: Add support for notes

Open juancarrey opened this issue 5 years ago • 4 comments

Hello,

I am building a basic diff&mege tool for excel files, and I am looking for support of read/write on Cell.Notes so that users can add notes to their "conflict resolution" on cells.

Do you have any guidelines for contribution ? Are you open to incorporate note support ? It might seem like a good feature that should not affect performance as I assume (not a raw excel format expert..) might be easy to do lazily,

Thanks

juancarrey avatar Feb 09 '20 20:02 juancarrey

There's already note/comment write support (https://github.com/dhatim/fastexcel/commit/45c9adcad9d1508fb7203f5c2aba82c6bb60c04e)

Comments are stored I separate file in xlsx (xl/comment1.xml), so this may be implemented lazily. The whole vml part may be ignored when reading.

rzymek avatar Feb 09 '20 22:02 rzymek

@juancarrey I hope you put your tool to github when it will be ready :)

kortov avatar Feb 10 '20 08:02 kortov

Is this feature (reading comments) still in demand ? I could take a bite at it.

rzymek avatar Apr 22 '20 17:04 rzymek

I ended up not really needing it, had some of it done and was doing some tests, but wasn't very happy with the approach though.

juancarrey avatar Apr 23 '20 10:04 juancarrey