Dharmit Shah

Results 113 comments of Dharmit Shah

@kandarpamalipeddi at the moment, this isn't a priority. Is this blocking you folks in any way? @prietyc123 when do you plan to pick this up from the QE side?

> A hint that the `--kube-version` defaults to a value at all would be useful when running `helm template --help`. I'm no helm expert, but I think it isn't the...

@aselunar I faced same issue. In my case, I clicked on the name of the domain I had registered on cloudflare. It asked me to "Authorize" the tunnel. When I...

/lifecycle frozen

> aggregated api server TIL. I hadn't heard of this before. Thanks! > FWIW, the SB from #8224 indicated that the `cattle-system/rancher` service has been down for a while But...

I have honestly got no clue about why there are so many lines modified in this PR. Steps I followed are below: ```sh $ export PACKAGE=rancher-monitoring/rancher-monitoring $ make prepare //...

@joshmeranda @alexandreLamarre thanks for your feedback, guys! I have modified as per your recommendations. Can you PTAL again? Thanks.

@joshmeranda I referred to the [Making Changes To Packages](https://github.com/rancher/charts/blob/dev-v2.9/docs/developing.md#making-changes-to-packages) section which mentions making version related changes first. In context of your comment, I followed steps 6-9 first and 1-5 after...

> I keep forgetting that the docs recommend you update the version first. That's fine as long as its a separate commit. Generally I'll update `package.yaml` in its own commit...

> I get that this feels somewhat nitpicky, but because of the sheer amount of files that are updated in charts PRs it makes it much easier for reviewers to...