Symbolism icon indicating copy to clipboard operation
Symbolism copied to clipboard

Commit 59c6a6f does not build on VS 2013 / VS 2015

Open ChaosCom opened this issue 7 years ago • 2 comments
trafficstars

Hello,

I've tried to compile the most recent build 59c6a6f on both VS 2013 as well as VS 2015 - without success.

Since the only 2 files that cause issues are PolynomialDivision.cs and PolynomialGcd.cs, I'm assuming it is due to the attempt to use tuples of the System.ValueTuple nuget package, for example

public static (MathObject quotient, MathObject remainder) PolynomialDivision(MathObject u, MathObject v, MathObject x)

Could you describe in detail how you made the project compile on VS 2013 / VS 2015 ?

ChaosCom avatar Dec 31 '17 19:12 ChaosCom

Hello!

I haven't built with VS2013 or VS2015 in quite some time. I've been exclusively using VS2017.

dharmatech avatar Dec 31 '17 19:12 dharmatech

Oh I see. Would it be perhaps possible for you to rewrite PolynomialDivision.cs and PolynomialGcd.cs so that they either use a custom PolynomialDivisionResult class (containing both fields) or use the framework System.Tuple class in order to retain compilation compatibility?

The commit before these 2 classes were introduced (2f7e681) still compiles under VS2013 with the Microsoft.Net.Compilers package (Version 1.3.2)

ChaosCom avatar Jan 01 '18 18:01 ChaosCom