Diggory Hardy

Results 281 comments of Diggory Hardy

Adding an `alloc` feature is quite straightforward. In the Rand lib we [make `std` depend on `alloc`](https://github.com/rust-random/rand/blob/master/Cargo.toml#L25) to avoid any ambiguity of what `std+alloc` does. The catch is that the...

Extracted from a [reddit post](https://www.reddit.com/r/rust/comments/fshuhk/introducing_tinyvec_100_safe_alternative_to/fm3tzqz/): [..] inspired me to have a quick look at uses of `unsafe` in the Rand crate. It would seem that uses can be categorised under:...

@alex ~no, but see [this post](https://www.reddit.com/r/rust/comments/fshuhk/introducing_tinyvec_100_safe_alternative_to/fm478zr/) to avoid redundant discussion.~ Possibly yes actually, though I think it requires a more recent compiler than our current MSRV of 1.32.

Rust 1.34 is also nearly a year old. I don't see any problem bumping to this version for the 0.8 release, which is what the master branch is already working...

I would love for this to be merged (I would like checkpointing with `pcg64`). @imneme would you be happy to merge this code, if @ahh completes it? It is of...

We have implemented a subset of these as a component of Rust's random number library: [rand_pcg](https://crates.io/crates/rand_pcg). One issue that came up is a difference in the construction of MCGs (e.g....

Hmm, the `Borrow` impls may violate the "soft requirements" on the `Borrow` type: > x.borrow() == y.borrow() should give the same result as x == y But `Ref` does not...

@rustbot label +T-libs-api -T-libs

Should we have a discussion issue for this lint? > If this lint introduces a panic it's highly likely the code wasn't functioning as intended to begin with I disagree:...

*Sigh.* The social perspective is the problem: a tool suggests a "fix", which can easily lead to people lazily following instructions. I guess at least any problem introduced is observable...