dhall-haskell icon indicating copy to clipboard operation
dhall-haskell copied to clipboard

dhall-docs tests failing on Windows

Open german1608 opened this issue 4 years ago • 6 comments

dhall-docs tests are failing on Windows, as this appveyor report says:

https://ci.appveyor.com/project/Gabriel439/dhall-haskell/builds/33971268

(found on #1901)

german1608 avatar Jul 08 '20 15:07 german1608

@german1608: The openTempFile error is due to naming the test after the file path:

https://github.com/dhall-lang/dhall-haskell/blob/e22ecde05f3cb858a0d5695dcd3ba3466b62cec2/dhall-docs/tasty/Main.hs#L59

This is because in the course of printing the diff tasty-silver uses the test name as the template string for a temporary file here:

https://github.com/phile314/tasty-silver/blob/1f511d2d84ccd0be3adac70c5b88a6dd791f309c/Test/Tasty/Silver/Interactive.hs#L223-L224

... and the logic for creating the temporary file doesn't like path separators in the template string.

If you fix that then the test failure will get further and display the actual diff that is causing the test to fail

Gabriella439 avatar Jul 09 '20 00:07 Gabriella439

Sorry for the interrupt, is there a guide on how you managed to compile a Nix + Haskell project for Windows. I'd like to replicate it for the https://github.com/srid/neuron project by @srid.

RoyiAvital avatar Jan 01 '21 00:01 RoyiAvital

@RoyiAvital: We only use Nix to build release binaries for Linux. For OS X and Windows we use stack to build the release binaries on Travis / Appveyor respectively

Gabriella439 avatar Jan 01 '21 16:01 Gabriella439

@Gabriel439 , Could you point me to see how? @srid , Do you know stack?

RoyiAvital avatar Jan 01 '21 17:01 RoyiAvital

@Gabriel439 , do you mean this: https://docs.haskellstack.org ?

RoyiAvital avatar Jan 01 '21 17:01 RoyiAvital

@RoyiAvital: Yes

Gabriella439 avatar Jan 01 '21 22:01 Gabriella439

I'm wondering if this issue is still relevant.

The dhall-docs tests run fine on Windows under github actions.

Is appveyor still in use? There is an appveyor.yml file in the repo that hasn't been touched in 3 years.

kukimik avatar Apr 12 '24 20:04 kukimik

Yeah, this issue is no longer relevant. The dhall-docs tests have been green for a while now and we don't use appveyor at all.

Gabriella439 avatar Apr 15 '24 02:04 Gabriella439

How about removing appveyor.yaml (and .travis*, if Travis is also no longer in use)? I think their presence may be confusing. If needed they can be restored using the VCS.

kukimik avatar Apr 15 '24 06:04 kukimik