dhall-haskell icon indicating copy to clipboard operation
dhall-haskell copied to clipboard

Published 20 hours ago • verified publisher icon dhall-lang

Retry certain failed HTTP requests?

Open sjakobi opened this issue 5 years ago • 3 comments

As discussed in https://github.com/dhall-lang/dhall-haskell/issues/1794, it might be useful to retry HTTP requests after certain failures. That might also help with the robustness of the testsuite: https://github.com/dhall-lang/dhall-haskell/pull/1808#issuecomment-633271566

sjakobi avatar May 29 '20 13:05 sjakobi

Note that for #1794 specifically it appears that retrying would not have helped (it was a persistent DNS resolution problem), but there may still be other cases where retrying is justified. We just need to catalog which http-client exceptions warrant a retry

Gabriella439 avatar May 29 '20 16:05 Gabriella439

Another instance of a flaky tests due to a network issue: https://github.com/dhall-lang/dhall-haskell/pull/1825#issuecomment-636372897

sjakobi avatar May 30 '20 20:05 sjakobi

I think it might be fine to make the number of retries configurable (either via the API, the command line, or both), but my intuition is that the default number of retries should still be zero. We would ideally like to fail as quickly as possible when something goes wrong.

Gabriella439 avatar Jun 12 '20 19:06 Gabriella439