Dan Halbert

Results 227 comments of Dan Halbert

Agree this can be closed.

Duplicating this comment: https://github.com/adafruit/Adafruit_ILI9341/pull/82#issuecomment-1238162503 > Pin numbers in Arduino are generally `uint8_t`, and the lower-level code generally assumes that. In this library and the other one you PR'd, `int8_t` is...

> Range of int8_t is between -128 and 127 so (int8_t) 204 become -54. Right, the bit representation is the same. It will be converted to a uint_8t at some...

The SPI clock rate setting at high clock rates on the SAMD chips goes by big jumps at high frequencies, because it's a small divisor value.. You may need to...

I mean that to get a higher SPI frequency than 24MHz, you may need to specify 48MHz, not just 32 or 33MHz. Anything in between will just take the nearest...

yes, try that, or even higher, but you have to change the Arduino menu items, as mentioned, and we don't guarantee it will work. I think 48MHz may be the...

Aha, I think the Board Support Package originally had a menu item to adjust the max SPI speed, and that was documented in the guide. However, we took that option...

Could you submit a PR for this? Thanks. That would be the easiest way to make sure it's corrected properly.

@FoamyGuy is this ready to finish up?

Hmm, I have to set the USB Stack option for the build: ``` 2023-07-31T00:37:57.1163264Z /home/runner/Arduino/libraries/Adafruit_TinyUSB_Library/src/Adafruit_TinyUSB.h:32:2: error: #error TinyUSB is not selected, please select it in "Tools->Menu->USB Stack" ``` Not sure...