highlight-escape-sequences icon indicating copy to clipboard operation
highlight-escape-sequences copied to clipboard

turn-on-hes-mode or turn-off-hes-mode doesn't apply to the current buffer

Open wigust opened this issue 7 years ago • 1 comments

Hello,

Thank you for this Emacs package!

I found some issues:

  • [ ] (turn-on-hes-mode) doesn't apply to the current buffer. To turn on hes-mode you need to M-x revert-buffer.
  • [ ] Same with (turn-off-hes-mode).

  • [ ] (turn-on-hes-mode) and (turn-off-hes-mode) works only globally, not locally for buffer.

  • [ ] Changing faces hes-escape-backslash-face and hes-escape-sequence-face via customize M-x customize-face doesn't work.

GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.21) of 2017-11-13

Oleg.

wigust avatar Nov 17 '17 23:11 wigust

Yes, it's a global mode. I didn't see much point in making a local version. (EDIT: never mind)

(turn-on-hes-mode) and (turn-off-hes-mode) works only globally, not locally for buffer

That is, apparently, how font-lock-add-keywords and font-lock-remove-keywords work. If there is a standard way to improve the situation, please let me know.

Changing faces hes-escape-backslash-face and hes-escape-sequence-face via customize M-x customize-face doesn't work

Works for me. At least, I set the foreground of the -backslash- face to red, clicked Apply, and that got applied immediately.

dgutov avatar Nov 18 '17 20:11 dgutov