Dan Guido

Results 83 comments of Dan Guido

@gustavo-grieco wondering if echidna finds this bug faster now, and this can get merged?

Hi @elenadimitrova, The issue with bad source references being incorrectly attributed to the wrong contract (where `strings` library findings were pointing to `BaseWallet.sol` instead of the actual location) has been...

@Ninja3047 @elopez - Thanks for the helpful reviews! I've addressed both comments in daed2ea9d: ## ✅ Fixed: PEP 735 Support (Ninja3047's comment) You were absolutely right - uv has supported...

## CI Fix Update The CI failures have been addressed with a proper, idiomatic solution for using `uv` in CI: ### The Problem When switching from `pip install` to `uv...

## CI Fix: Missing Python/pip wrappers Fixed the latest CI failure in 3a6d5105d. The issue was incomplete wrapper coverage in `ci_test_common.sh`. **The problem:** ```bash ModuleNotFoundError: No module named 'slither' ```...

I've addressed both issues mentioned in the PR comments and made an additional improvement: ## Changes Made: ### 1. ✅ Fixed PEP 735 Migration (addressing @Ninja3047's comment) Successfully migrated from...

## CI Fix Update Just pushed a fix for the failing CI tests. The issue was that `solc` (installed by `solc-select`) wasn't accessible when running through `uv run` in the...

@elopez Yes :(. I was trying to be as idiomatically correct about it as I could, but that is probably easier at this point. I will change it.

This is a great enhancement proposal that would complement the existing `slither-check-erc` tool nicely. ## Current State vs Proposed Enhancement The existing `slither-check-erc` tool already provides comprehensive ERC compliance checking,...

## Analysis: Relationship to Existing `incorrect-equality` Detector After reviewing the existing codebase, I found that Slither already has partial coverage for balance-related issues through the `incorrect-equality` detector (`slither/detectors/statements/incorrect_strict_equality.py`). However, the...