changedetection.io icon indicating copy to clipboard operation
changedetection.io copied to clipboard

Empty diff triggers change detection

Open Noki opened this issue 6 months ago • 10 comments

Describe the bug

I sometimes get change detection notifications even though the diff is empty. My notification body setting looks like this:

{{watch_title}} / {{watch_url}} had a change.<br><br>

see diff: {{diff_url}}<br>
---diff---<br>
{{diff}}<br>
---diff---<br>

Whenever it happens the notification looks like this:

image

[...] had a change.<br><br>

see diff: http://diskstation:3003/diff/040867f4-9a48-4a24-b4e1-9f6b2b84b626<br>
---diff---<br>
<br>
---diff---<br>

In addition I can't download the latest HTML snapshot:

image

Version

v0.46.02

To Reproduce

Can't reproduce. Can't share the check, as it contains sensitive information. Best guess: An internal error is not handled properly. It might have to do with the "Remove elements" and "Block change-detection while text matches" features, which I both use for the check. Maybe a blocked change detection still stores data and the following run is incorrectly compared against it.

I found the following in the docker logfile:

image

It clearly states that the hash is different.

image

Expected behavior

Never send out notifications in case of an empty diff. Do not detect a change in this case.

Noki avatar Aug 05 '24 10:08 Noki