spyscope icon indicating copy to clipboard operation
spyscope copied to clipboard

Colorization

Open kendagriff opened this issue 9 years ago • 7 comments

Any interest in incorporating puget for colorization, either as the out-of-the-box or optional behavior? I'd be happy to submit a pull request.

If not, any suggestions on how to make them work together?

kendagriff avatar Oct 19 '15 17:10 kendagriff

Yes, I think that'd be a great enhancement. Does puget have integration with vim and emacs for in-editor coloring? Either way, fipp would enable removing some of the synchronization code that specifically handles performance issues with pprint running in parallel. On Mon, Oct 19, 2015 at 1:18 PM Kendall Buchanan [email protected] wrote:

Any interest in incorporating puget https://github.com/greglook/puget for colorization, either as the out-of-the-box or optional behavior? I'd be happy to submit a pull request.

If not, any suggestions on how to make them work together?

— Reply to this email directly or view it on GitHub https://github.com/dgrnbrg/spyscope/issues/18.

dgrnbrg avatar Oct 20 '15 19:10 dgrnbrg

https://github.com/dgrnbrg/spyscope/pull/19

kendagriff avatar Nov 23 '15 20:11 kendagriff

hi. is there any way of disabling colorization? i sometimes run my tests inside an emacs compilation buffer and i'd rather not have ansi colors there... thanks!

jaor avatar Jun 06 '17 21:06 jaor

@jaor It's probably a simple PR, but you might look at this https://github.com/greglook/puget, too.

kendagriff avatar Jun 07 '17 14:06 kendagriff

On Wed, Jun 07 2017, Kendall Buchanan wrote:

@jaor It's probably a simple PR, but you might look at this https://github.com/greglook/puget, too.

thanks kendall. i looked around, but since it's spyscope whose calling puget under the rug, i didn't see an easy way of telling #spy/p to pass printer configuration params in its calls to puget. i guess i can set somewhere in my ~.lein/profiles.clj a binding for puget.printer/*options*, but i was wondering whether there was something quick on spyscope's side.

jaor avatar Jun 07 '17 16:06 jaor

I think that setting the binding is your best bet. I was going to suggest adding a binding to spyscope, but since puget already has that, you should be set!

dgrnbrg avatar Jun 07 '17 17:06 dgrnbrg

On Wed, Jun 07 2017, David Greenberg wrote:

I think that setting the binding is your best bet. I was going to suggest adding a binding to spyscope, but since puget already has that, you should be set!

i still think a spyscope-specific setting would be a good idea, and would also protect your users from surprises the day you decide to switch from puget to something else (if that day ever arrives; but then a switch has already happened, and it has surprised me for one).

fwiw, imho, etc.

thanks!

jaor avatar Jun 07 '17 18:06 jaor