Dan Grebb

Results 32 comments of Dan Grebb

Thank you @gruberro for finding this — submitted #1556 to fix.

This is not an engine option, but a param for the [`screenshot` API](https://playwright.dev/docs/api/class-locator#locator-screenshot). E.g. `await page.getByRole('link').screenshot({ animations: 'disabled', path: 'link.png' });`. @Alexbirvik I, too, have tried but was never successful...

Thanks for the work on this @Neychok — I submitted [a new PR](https://github.com/garris/BackstopJS/pull/1511) which will work with backwards compatibility in mind.

I'm not sure I follow. The idea was to run sanity tests to ensure the project runs as expected, basically following the README to ensure it runs after any changes...

Yeah - testing a testing product definitely isn't straight-forward The intent was to provide a quick view into PR health, and make merging decisions easier. I'll do some more research...

Also @garris if you'd rather me make everything fail by default let me know - happy to do this as well.

@garris I have an idea! After I work through 'headless: new', I'm going to play around with some test fixtures of the report json. We can validate sanity/smoke test output...

tl;dr we're going to use `jq` and `diff`, which are built in, to test targeted pieces and the shape of generated `reports.json` after various npm tests are run. Here's a...

This can be manually fixed in `package.json` by overriding `proxy-agent` for now. When puppeteer does so in their dependencies, it will organically find its way into backstop. For example: ```json...

All set with #1493. Also added `--colors` flag to `remote` `child_process.exec` so we can have colors everywhere :) @garris hope this helps!