ristretto icon indicating copy to clipboard operation
ristretto copied to clipboard

Published 20 hours ago • verified publisher icon dgraph-io

performance for get shards index

Open linger1216 opened this issue 4 years ago • 3 comments

because numShards is power of two, so can use & operator for performance

This change is Reviewable

linger1216 avatar Mar 24 '20 08:03 linger1216

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 24 '20 08:03 CLAassistant

merging is blocked , reason is

Function call made to an unsafe package Found in z/bbloom.go and z/rtutil.go

It has nothing to do with this merge  

linger1216 avatar Mar 24 '20 14:03 linger1216

Hey @linger1216 , the PR doesn't have benchmarks to support the performance improvement claim. Could you please point me to some references about % and & operator performance? A quick google search didn't give me anything useful.

Also, the merging is blocked because you haven't signed the CLA.

jarifibrahim avatar May 28 '21 06:05 jarifibrahim