dgraph icon indicating copy to clipboard operation
dgraph copied to clipboard

fix(zero): Made zero health endpoint to return json as alpha's health

Open tharun208 opened this issue 4 years ago • 11 comments

Signed-off-by: Tharun [email protected]

fix(zero): Made zero health endpoint to return JSON as alpha's health

Fixes #5517


This change is Reviewable

tharun208 avatar Jun 24 '20 20:06 tharun208

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 24 '20 20:06 CLAassistant

Could you also post the output with your changes?

Screen Shot 2020-06-26 at 12 48 51 PM

tharun208 avatar Jun 26 '20 15:06 tharun208

FYI, @martinmr

manishrjain avatar Jul 07 '20 12:07 manishrjain

@tharun208 , can you push this in? It has been approved.

parasssh avatar Aug 22 '20 05:08 parasssh

@tharun208 , can you push this in? It has been approved.

@parasssh , should i need to manually merge this with master ?

tharun208 avatar Aug 22 '20 06:08 tharun208

@tharun208 , can you push this in? It has been approved.

@parasssh , should i need to manually merge this with master ?

Yes. You have the approvals. Should be good to merge

parasssh avatar Aug 22 '20 06:08 parasssh

@tharun208 , can you push this in? It has been approved.

@parasssh , should i need to manually merge this with master ?

Yes. You have the approvals. Should be good to merge

I am unable to merge pull request to upstream master.

tharun208 avatar Aug 22 '20 06:08 tharun208

@tharun208 , can you push this in? It has been approved.

@parasssh , should i need to manually merge this with master ?

Yes. You have the approvals. Should be good to merge

I am unable to merge pull request to upstream master.

@danielmai , any ideas? I see all the required checks are fine.

parasssh avatar Aug 22 '20 07:08 parasssh

can we merge this ?. I am not a member and I cant merge this by default

tharun208 avatar Mar 01 '21 20:03 tharun208

coming after 1 year. can we merge this 😅 ?

tharun208 avatar Jun 10 '21 11:06 tharun208

@parasssh is it good to merge or can i close this ?

tharun208 avatar Jan 31 '22 10:01 tharun208

hey @tharun208, sorry for all this delay. We have renamed master to main. So, you need to re-do the PR pointing to main. Or maybe you could rebase this PR. I can point it to main from my side and then you fix it doing rebase. We can try that.

Or just close it and reopen. Your call.

MichelDiz avatar Jan 09 '23 17:01 MichelDiz

PS. I gonna track this for a month. If you don't see that, I'll try to do something myself. If you can't keep your name in the commits, the solution will be to copy the code and do the PR myself.

MichelDiz avatar Jan 09 '23 17:01 MichelDiz

closing this PR in lieu of #8766

mangalaman93 avatar Mar 20 '23 19:03 mangalaman93