badger icon indicating copy to clipboard operation
badger copied to clipboard

`refactor(protobuf): [Breaking]` Use `google.golang.org/protobuf`

Open lrh3321 opened this issue 11 months ago • 4 comments

Problem

  1. github.com/golang/protobuf and https://github.com/gogo/protobuf were deprecated.
  2. XXX_DiscardUnknown, XXX_Marshal, XXX_Merge, XXX_Size, XXX_Unmarshal methods for structs in badgerpb4.pb.go are removed.

Solution

  1. Use google.golang.org/protobuf/cmd/protoc-gen-go to generate badgerpb4.pb.go
  2. Add Size, Marshal, MarshalTo, MarshalToSizedBuffer, Unmarshal methods to pb.KV, pb.DataKey, like protoc-gen-gogofaster does.
  3. Replace the imports

lrh3321 avatar Mar 30 '24 15:03 lrh3321

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 30 '24 15:03 CLAassistant

Deploy Preview for badger-docs canceled.

Name Link
Latest commit 56a7f61068b85ee0925b8210ee6991576e20415f
Latest deploy log https://app.netlify.com/sites/badger-docs/deploys/66082f888510dd000811d4f5

netlify[bot] avatar Mar 30 '24 15:03 netlify[bot]

This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

github-actions[bot] avatar Jul 12 '24 01:07 github-actions[bot]

Still relevant

paralin avatar Jul 12 '24 03:07 paralin