Dimitris Grammatikogiannis

Results 187 comments of Dimitris Grammatikogiannis

@obuisard let me give you a rough idea of what I'm talking about with this `stream` approach: - Instead of the standard json the media manager (for the getFiles fn,...

> The stream approach doesnt change the functionality of the media manager - ux Of course it doesn't as it shouldn't, this is a low level optimisation of the Request/Response...

> what you have suggested not very performance friendly for media manager What's not `very performance friendly`? The client side will render things progressively meaning that the response will be...

> You suggest to dump a whole file list, reqursively. It does not mater how it will be send to browser as stream or all at once, it will be...

@JanCizmar sure, here you go: https://github.com/joomla/joomla-cms/blob/4.1-dev/language/en-GB/com_config.ini The use case is the Joomla CMS

Oh, I thought you weren't interested to support such files...

Sounds good, thanks

@LeaVerou I reviewed your repo and did some of the changes @toofff mentioned above with this [PR](https://github.com/LeaVerou/dragula2/pull/1). It would be awesome if you could push the changes in this repo...

Is `thump_path` always the same as the `url`? If so then remove it in the Media manager Api, but I think that thump is for a thumbnail provided by some...

> So the value filled in has to be Joomla.selectedMediaFile.url to functional. Yes, you're right. FWIW the thumb part shouldn't be there but rather in https://github.com/joomla/joomla-cms/blob/acb3b6d66582d6b3467731680b4813536eccf53e/build/media_source/system/js/fields/joomla-field-media.w-c.es6.js#L159-L187 something like: ```js updatePreview()...