Dmitry Petukhov

Because bitcointx uses type hints directly expressed in source (only supported since python3.6) taking type hint code from bitcointx would transfer the python3.6 requirement of bitcointx to bitcoinlib.

I've implemented for bitcointx: https://github.com/Simplexum/python-bitcointx/pull/54 For bitcoinlib that might be more involved because it still uses openssl by default

My codebase in this area is very different now. secp256k1 is used exclusively and not optionally. `key.sign()` in bitcointx is still descended from ` _sign_with_libsecp256k1` that I submitted to bitcoinlib...

> just loop the sig call till you get a small one. Not sure if the OpenSSL sigs get that small though. The code in Bitcoin Core and electrum is...

`getnewaddress()` alters the state of the wallet in the bitcoind that is connected to. Since bitcoinlib tries to connect using parameters from `~/.bitcoin/bitcoin.conf`, it can access the user's "non-test" bitcoind...

https://github.com/petertodd/python-bitcoinlib/pull/187

``` >>> from bitcoin.core import * >>> from bitcoin.core.script import * >>> >>> raw_txid = '010000000190664219e4eedfc97020d7a7bacddaaf5abbe20e3f0a5e77e9ae85bcdf6a0fd0910000006f0047304402207bf94f0f703364bbc008fe814061a36f421a59153b49131b828e583802cb13670220301095b2cb26623840455155e97ed1831d05a50798128a21ae83e38e8bcd90680125512102494948b6192ca3615e443c10ec058497c2b6785c9c960940de15583930ad97c751aeffffffff01900e4d000000000017a914497d58d263bd82b460bdc9b8c69ca6e25acc99938700000000' >>> ctx = CTransaction().deserialize(bytes.fromhex(raw_txid)) >>> >>> publickey = '512102494948b6192ca3615e443c10ec058497c2b6785c9c960940de15583930ad97c751ae' >>> value = int(0.051*COIN) >>>...

and on v0.10.2 the assertion still happens.

I just took this code snippet from the first message, and run it on the last version of the library. It did not cause exception. Then I checked out v0.10.2,...

I mean, this shows that #187 fixed the issue. The transaction in this issue contains 1-of-1 p2sh script: ``` >>> from bitcoin.core import * >>> from bitcoin import * >>>...