Dmitry Petukhov

Results 69 comments of Dmitry Petukhov

As I understand, the native code dependencies are not distributed with bitcoinlib, because they are widespread (openssl and libsecp) On the other hand, bitcointx has an interface to libbitcoinconsensus with...

Formal spec for miniscript: https://github.com/dgpv/miniscript-alloy-spec

I've handled it this way: https://github.com/Simplexum/python-bitcointx/blob/e3e3726d53c3948ed249ee79cf2b808c7f875add/bitcointx/core/__init__.py#L1100-L1108 Note that this does not allow a transaction with empty inputs, and the unserialize code in Core allows it, but for the case when...

I thought a bit about my solution and decided that it was not entirely adequate, as indeed deserializing empty transactions can be useful in some contexts. So I decided to...

> Moreover & 1 and ^=1 may work as intended also in python, but in cpp may have a different meaning, it may work, I didn't test it, it just...

I've added pull request with straightforward implementation (checking for presence and enabling signing with libsecp256k1 are done just with two exported functions) https://github.com/petertodd/python-bitcoinlib/pull/185 @petertodd, do you think pluggable ECC library...

The libsecp256k1 support added by #185 is optional, and the signing is with openssl by default. I think the discussion on if it makes sense to ditch openssl entirely and...

Looks like the code that handles uncompressed pubkeys with bare checksig takes one byte short of the pubkey: https://github.com/petertodd/python-bitcoinlib/blob/73110cb22d66af51cdff9d4d50f088c80b4c496a/bitcoin/wallet.py#L195

> One could rebase Simplexum@b275373 I don't think that it would be that simple, there was significant incompatibe changes made at this stage. But it could cover some portion of...

Python2 is declared unsupported since v0.11.0 (in release-notes for v0.10.2, "Note: this will be the last release of python-bitcoinlib with Python 2.7 compatibility."), I believe what @ysangkok meant is that...