Dmitry Petukhov

Results 69 comments of Dmitry Petukhov

Made the reference to the whole "Satisfaction and malleability" section in the note, as not only the "Basic satisfactions" subsection is relevant, but other text there, too

I think this should be a footnote or some other clarification in the text so the readers would not be confused. I wasn't able to come up with good text...

Would this sentence be correct? > It might be possible to construct a witness such that the script execution will not match the listed semantics; the execution in this case...

Maybe just add a note > Semantics are defined for canonical satisfaction/dissatisfaction options, and may not be valid for non-canonical options (see "Satisfaction and malleability", "Basic satisfactions" below)

I voiced my concerns about changing the behavior of `encode_op_n`/`decode_op_n` in the Core's issue linked in the first message, but here I want to mention that if you proceed with...

we just substituted connection object in BaseProxy with our own wrapper class, that handles reconnections itself. https://github.com/petertodd/python-bitcoinlib/pull/188 retrying bitcoind RPC calls is not an issue for us, because we use...

the use of `int()` may be a problem on python2, but as far as I remember, python-bitcoinlib is announced to be python3-only from the next release.

> Is there anything else you'd do if this pull-req was py3-only? No, this code was ported from python-bitcointx, which is py3-only from the start.

python-bitcointx's scripteval.py (https://github.com/Simplexum/python-bitcointx/blob/master/bitcointx/core/scripteval.py) supports segwit, but I feel it will require some work to backport. Easier way might be to backport an interface to bitcoinconsensus library: https://github.com/Simplexum/python-bitcointx/blob/master/bitcointx/core/bitcoinconsensus.py -- there's not...

Now that Bech32-encoded address support is merged you probably want to add `BECH32_HRP` parameter, too EDIT: confused this with signet (https://en.bitcoin.it/wiki/Signet), this 'simnet' seems to be something else - the...