smiley-slider
smiley-slider copied to clipboard
dglittle
Compatibility in IE9
I'm starting to use smiley-slider and found out that it doesn't work in IE9. I've tracked the problem to the use of const to define PI180 and SEGS. IE9 doesn't supports const types so I just changed from const to var and it works just fine. I don't know if this will bring any other problems or not but so far so good.
thanks for this nice widget José Tavares
I think that fix is good.. if you submit a "pull request", I will add it :)
On Mon, Dec 12, 2011 at 6:49 AM, zarroba [email protected] wrote:
I'm starting to use smiley-slider and found out that it doesn't work in IE9. I've tracked the problem to the use of const to define PI180 and SEGS. IE9 doesn't supports const types so I just changed from const to var and it works just fine. I don't know if this will bring any other problems or not but so far so good.
thanks for this nice widget José Tavares
Reply to this email directly or view it on GitHub: https://github.com/dglittle/smiley-slider/issues/2
Just started the pull request. It was the first time I worked with GitHub, thanks for the opportunity!
I noticed another issue with IE9. I can't slide the smiley by clicking directly on it and dragging. I can only slide it by clicking on any other point of the slider and then dragging. No idea why though...
awesome -- it has been merged. thanks!
On Fri, Dec 16, 2011 at 1:59 AM, zarroba [email protected] wrote:
Just started the pull request. It was the first time I worked with GitHub, thanks for the opportunity!
Reply to this email directly or view it on GitHub: https://github.com/dglittle/smiley-slider/issues/2#issuecomment-3175393
oh, that's unfortunate.. I don't have easy access to IE9, so it's hard for me to test. If you do figure it out, let me know.
On Fri, Dec 16, 2011 at 2:01 AM, zarroba [email protected] wrote:
I noticed another issue with IE9. I can't slide the smiley by clicking directly on it and dragging. I can only slide it by clicking on any other point of the slider and then dragging. No idea why though...
Reply to this email directly or view it on GitHub: https://github.com/dglittle/smiley-slider/issues/2#issuecomment-3175401