Dan Gebhardt

Results 27 comments of Dan Gebhardt

`ember-engines` relies on addons' cache keys to uniquely identify each version and should only dedupe addons with matching cache keys. Every addon with a unique version will also have a...

Thanks for keeping progress on the router moving, @villander. I'm unclear on how this proposal intersects with: > Consider allowing an experimental build flag to allow usage of an alpha...

> No! it's the same, we going to release the engine-specific (i.e. route.external) with the build flag as an experimental feature. It's only a breakdown Gotcha, thanks for clarifying. So...

#605 has been merged, which adds a warning. We can keep this issue open until we add hard errors for 1.0.

@villander getting close imo! I think we're down to needing a couple tests for the events above, and my main concern which is: > One of my major concerns here...

This PR has dragged on for quite a while and I'd like to move it forward ASAP. That said, I was just doing another walkthrough here and could use some...

Thanks for your thoughts, @villander and @buschtoens. > Looking forward to seeing it merged and released. @villander Same here, but my hesitation is that this PR creates a whole lot...

> By doing just this we would break support for dependencies.externalRoutes. Apologies. It's been so long since I've used engines personally that I completely overlooked current support for [external routes](https://ember-engines.com/docs/links#external-routes)....

Rebased onto #18490. Should be able to rebase down to a single commit once that lands on `main`.