Daniel Smith
Daniel Smith
@janeyx99 Apologies, I'm traveling for the next week and will be slow to respond. @jcmgray Can you get eyes on this?
@janeyx99 Thoughts here?
@jcmgray / @janeyx99 Gentle pings here on solutions. I don't have a strong opinion, but it would be nice to keep this moving.
@janeyx99 Given PyTorch has likely moved on since this PR was made and deprecated older versions, what is optimal to do here?
My understanding was this PR would be optimal from a Torch perspective. If it's no longer needed or if Torch's minimum supported version no longer requires this patch, we can...
@janeyx99 Ah- I would recommend having `PyTorch` skip `contract_path` when `len(operands)
@janeyx99 Got it, then we only deal with the edge case where it's optimal to perform a three-product Hadamard or similar. The performance hit is likely quite minimal. Would you...
I didn't get to every test yet. I'll hack a bit this weekend.
@janeyx99 Is this still of interest to Torch? I think we're relatively close on removing that last of the NumPy dependancies.
Apologies- I started a new job. This is in my mind and I hope to hack a little tomorrow night!