David Garske

Results 356 comments of David Garske

@cconlon I am going to squash merge this. Thanks!

Hi @t0x1c , That is great you discovered it was an endianness issue. Do you have a solution to it? The endianness build option `BIG_ENDIAN_ORDER` or `WORDS_BIGENDIAN` should get set...

Hi @t0x1c , Excellent find with the alignment. Would it make sense to have 4 byte alignment set on the structure like `#pragma pack(push, 4)`? I'll work on putting a...

Hi @t0x1c , I've put up a fix here: https://github.com/wolfSSL/wolfssl/pull/4908 Let me know if that works for you. If not let me know if you see padding issue on the...

Hi @t0x1c , Glad to hear PR 4908 fixed the issue! I'll assign it for merge. If you clone from GitHub you need to run `./autogen.sh` first to build the...

> > We will need to squash this commit. Found some whitespace issues: > > ``` > > [...] > > ./wolfssl/wolfcrypt/settings.h:2758:»(defined(HAVE_PKCS11) || defined(HAVE_PK_CALLBACKS) || \ > > ./wolfssl/wolfcrypt/settings.h:2759:» defined(WOLF_CRYPTO_CB)...

@sjaeckel ``` ./wolfcrypt/src/include.am: wolfcrypt/src/port/xilinx/xil-versal-glue.c \ ./wolfcrypt/src/include.am: wolfcrypt/src/port/xilinx/xil-versal-trng.c \ ./wolfssl/wolfcrypt/include.am: wolfssl/wolfcrypt/port/xilinx/xil-versal-glue.h \ ./wolfssl/wolfcrypt/include.am: wolfssl/wolfcrypt/port/xilinx/xil-versal-trng.h \ AUTOCONF NEW FILE DETECTOR FAILED! ```

> @sjaeckel > > ``` > ./wolfcrypt/src/include.am: wolfcrypt/src/port/xilinx/xil-versal-glue.c \ > ./wolfcrypt/src/include.am: wolfcrypt/src/port/xilinx/xil-versal-trng.c \ > ./wolfssl/wolfcrypt/include.am: wolfssl/wolfcrypt/port/xilinx/xil-versal-glue.h \ > ./wolfssl/wolfcrypt/include.am: wolfssl/wolfcrypt/port/xilinx/xil-versal-trng.h \ > AUTOCONF NEW FILE DETECTOR FAILED! > ``` Disregard.....