David Garske comments

Results 356 comments of


                                            David Garske

Fix CMakeLists.txt file

Hi Felix, Thank you for this contribution. In order to accept this we need to have a signed contributor agreement on file. Please send an email to support @ wolfssl.com...

Fix CMakeLists.txt file

@topazus , thanks for the email and while the contributor agreement is in progress, I am asking @JacobBarthelmeh to review this.

[Bug]: `wolfSSL_get_keys` without ifdefs in header, but with ifdefs in c file

Hi @laurenzfg , You might need to call `wolfSSL_KeepArrays(ssl);`. We have a full TLS v1.3 example for using the secret callbacks for key log here: https://github.com/wolfSSL/wolfssl-examples/blob/master/tls/client-tls13.c#L218 I also asked @bigbrett...

Fix benchmark failure on FIPS builds

Retest this please

Fix benchmark failure on FIPS builds

Retest this please

Fix benchmark failure on FIPS builds

Can't seem to get it to re-test or pass this macOS check in GitHub CI. I went ahead and rebased and force pushed. Let's see if we still get a...

honor Espressif fp_int used length in s_fp_add operands

The Jenkins failure is a FIPS issue. Is it possible you broke something else? ``` [0m[5/15] ./vectors-v2/CCM/req/VADT192.req OUT = ./vectors-v2/CCM/rsp/VADT192.rsp Expected: Diffing ./vectors-v2/CCM/rsp/VADT192.rsp with ./vectors-ERROR: -251

Software-only support for recent esp32 targets

OK to test