dibi
dibi copied to clipboard
dg
PdoDriver: fix pdo connection in exception mode (target >=4.1.0)
- new feature
- BC break? no (as original behaviour should be considered as broken)
see #292
There is one more problem to fix, there is also WARNING mode in which dibi probably should mute warnings and handle them by iteself consistently = throwing exception.
I would like to write few notes into comments into this function because it handles three things simulatanously and it is not obvious what is does for the first look.
One more thing - I will need to help a little with tests. What approach to go? Run all tests also in warning mode and exception mode? Or create just unit tests for this one function. I'm not shure what happend whan connection dies before ->rowCount() is called.
Run all tests in warning mode and exception mode seems better to me.
I'm not shure what happend whan connection dies before ->rowCount() is called.
It's hard to test, I would probably let it go.
Run all tests in warning mode and exception mode seems better to me.
How to do that? Tester does not support running more @dataProviders. I will probably go for unit test specially for PdoDriver::query() and running that with more configurations.
Running all tests with different configuration can be made by passing evironemnt variables to tester runner and passing that to individual tests. These evironment variables can be then listened in boostrap.php and there it can be decided with way to setup PDO.
@dg It is more complicated then it looked at first time. There are still unhandled getAttribute, startTransaction, ... calls which leaks exceptions. What about wrapping PDO connection into evelope which normalizes errors. Current approach would make PdoDriver quite complex. Alternative approach is to wrap pdo calls in "javascript way".
self::try(function() {return $this->connection->getAttribute();}, function () {success}, function() {failure});
However this leads into weakly typed code as PHP does not support generics.
Another option is to have two drivers, one for exception mode and one for warnings mode. And forbid silent mode (it is nonsense mode).
And another one option: to switch PDO to warning mode and back before and after each operation.
As PDO can provide consistent API when configured, I will try to go for switching error modes. Hopefuly that will hot have any side effects. There should be none - as long as there will be no nesting or callbacks from inside of the driver.
BTW problem with silent mode is that it is default. Current implementation of PdoDriver relays on silent mode.
API that changes by configuration is hell🔥.
Hi, can I somehow help with this to get it merged? Would be pretty helpful in a project of mine.
@PavelJurasek You can go through the comments and try to solve problems that are left.
As I see this now from bigger perspective. Could you please try to implement three PdoDrivers, for each mode? They each have different API and it is huge mess to try to implement it in one class. If you wish I can go through the current proposal if you wish.
@jkuchar hi, there is a rough draft of split https://github.com/dg/dibi/commit/67b32f9a2df28f5151a843ca5c5ceb201e6bb2ce
I really don't like "Base" keyword in abstract driver name, but dunno how to name it 🤷♂️
On the bright side - default mode is exception mode since php8.0 🙂
@jiripudil Could you please go through these changes? I'm quite busy this week. :)
Rebased and fixed some of the tests in https://github.com/PavelJurasek/dibi/tree/fix-pdo-connection-in-exception-mode
@dg @jkuchar is there something else I could do to push this forward?