dfuse-eosio icon indicating copy to clipboard operation
dfuse-eosio copied to clipboard

Confusion around the global `nodeos-path` and the `node-manager-nodeos-path` & `mindreader-nodeos-path`

Open maoueh opened this issue 4 years ago • 0 comments

When we init or start, we check if nodeos version is supported by the binary. The check use the global-nodeos-path value to resolve which binary to use.

However, node-manager and mindreader both have a a different option for nodeos path and they are not connected to the global value at all.

So it's inconsistent. At the same time, it might be valuable to have a different option for the two value.

Suggestion of fix:

  • The default of node-manager should resolve to global-nodeos-path value
  • The default of mindreader should resolve to global-nodeos-path value
  • When they are overridden, they take precedence
  • When we do the nodeos check for mindreader, we should check the resolved value of mindreader-nodeos-path.
Quirks

The resolution graph of values is rather hard to get right. We will need to test various things like ensuring a "global value" set in a config file is properly propagated as the default value of mindreader & node-manager.

maoueh avatar Jun 26 '20 14:06 maoueh