Dominik Fuchß
Dominik Fuchß
I'll add it to the current milestone :) Let's see whether we manage to merge this in this or the next milestones :)
> Additionally, there is a related client test failure due to the additional feature toggle in `AdminFeatureToggleComponentTest › onInit test if features mapped successfully`. I've fixed the test. I simply...
As a follow-up PR, we can think about changing the mechanisms of FeatureToggles in a way that you can specify whether Features are enabled or disabled by default. For now,...
> A feature toggle (runtime switch) does not make sense in this case in my opinion. They are active by default and decisions are reset after restarting the servers. >...
⚠️ **The PR seems not to update to the current commits :(** ⚠️ Please simply look at https://github.com/kit-sdq/Artemis/tree/feature/personal-access-token for now. We have to wait until github updates its UI
@LDAP if the GitHub UI does not update, I would simply suggest to open a new PR and close this one :)
Thanks for the detailled protocol and suggestions :) > * Test that Artemis sets correct headers, so that a malicious application can not generate a token when the user is...
> > > From an admin user experience, is there any benefit in setting the token length in milliseconds over minutes/days? > > > > > > I don't think...
I've converted the lifetime to seconds (in the config). The other config (e.g., some lines above for athene uses seconds as well)
On hold for now.